Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load native code when not running on a recognized board #364

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

FDelporte
Copy link
Member

Use board type to prevent errors while loading native libraries during development on non-Raspberry Pi.

@eitch can you please review if these are the right places to implement this? I have the feeling it should be somewhere "on a higher level", but not sure where...

@FDelporte FDelporte requested a review from eitch June 10, 2024 08:43
Copy link
Member

@eitch eitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Every plugin does its own work, so i think this is fine. Should do it in the other plugins as well, where we don't have native libraries. pigpiod and LinuxFS. LinuxFS might work on a Linux platform, but not on Windows...

@FDelporte FDelporte merged commit 9fca5dc into develop Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants